don't spread props.insertImages into the dom element

sjdemartini · Jan 8, 2024 · ec7b064 · ec7b064
1 parent 021af5f
commit ec7b064
Showing 1 changed file with 7 additions and 3 deletions.
diff --git a/src/controls/MenuButtonImageUpload.tsx b/src/controls/MenuButtonImageUpload.tsx
@@ -2,7 +2,10 @@ import type { Editor } from "@tiptap/core";
 import { useRef, type ComponentPropsWithoutRef } from "react";
 import type { SetOptional } from "type-fest";
 import { useRichTextEditorContext } from "../context";
-import { insertImages, type ImageNodeAttributes } from "../utils";
+import {
+  insertImages as fallbackInsertImages,
+  type ImageNodeAttributes,
+} from "../utils";
 import MenuButtonAddImage, {
   type MenuButtonAddImageProps,
 } from "./MenuButtonAddImage";
@@ -52,6 +55,7 @@ export interface MenuButtonImageUploadProps
 export default function MenuButtonImageUpload({
   onUploadFiles,
   inputProps,
+  insertImages,
   ...props
 }: MenuButtonImageUploadProps) {
   const editor = useRichTextEditorContext();
@@ -64,9 +68,9 @@ export default function MenuButtonImageUpload({
     }
     const attributesForImages = await onUploadFiles(Array.from(files));
     if (typeof props.insertImages === "function") {
-      props.insertImages({ editor, images: attributesForImages });
+      insertImages({ editor, images: attributesForImages });
     } else {
-      insertImages({
+      fallbackInsertImages({
         editor,
         images: attributesForImages,
       });