Revamp and reorganize menu components to be user-provided instead of hard-coded #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't actually *use* the `value` anywhere right now, it's just an excessive field that's required by MUI for the purposes of controlling MenuButtonGroups. So this makes it optional, with the default set as the `tooltipLabel`, so it can still satisfy MUI (and could still be used in a button group successfully), but still allows callers to use an explicit `value` if they want.
sjdemartini
added a commit
that referenced
this pull request
Jun 12, 2023
As of #22, no longer used.
sjdemartini
added a commit
that referenced
this pull request
Jun 12, 2023
As of #22, no longer used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.