Update types to support MUI v5.15.11+ types #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of mui/material-ui#39137, MUI's `SelectProps` is now a `type` and not an `interface`, so we can no longer `extend` it for our own `MenuSelectProps`. As such, we now make `MenuSelectProps` a `type` and use `&` syntax to inject additional props. This should support both MUI < v5.15.11 (where `SelectProps` is an `interface`) and >= 5.15.11 (where `SelectProps` is a `type`).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of newer MUI versions, we require a couple adjustments to remain compatible. (The changes in this PR should be compatible with lower versions of MUI as well, but now ensure we don't break when users are installing newer MUI versions. Peer dependencies are still early MUI v5.)
SelectPropsis now atypeand not aninterface, so we can no longerextendit for our ownMenuSelectProps. As such, we now makeMenuSelectPropsatypeand use&syntax to inject additional props. This should support both MUI < v5.15.11 (whereSelectPropsis aninterface) and >= 5.15.11 (whereSelectPropsis atype).fontSizedefinition has gotten more strict, so this works around the issue.This also updates the dev dependencies within mui-tiptap to use the newest MUI, for easier testing of these changes.