Lint against more extraneous dependencies being imported #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No devDependencies should be imported in the main project without also appearing in peerDependencies. Otherwise we risk the package breaking when installed for others. And because we publish our types with our package, even Type imports should need to be included in dependencies or peerDependencies. So `type-fest` should really be listed as a direct dependency (as it is for other major users of type-fest, like yup, snakecase-keys, etc., and as described here sindresorhus/type-fest#136 (comment)).
sjdemartini
force-pushed
the
lint-for-extraneous-deps
branch
from
fa3643e to
824eec9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No devDependencies should be imported in the main project without also appearing in peerDependencies. Otherwise we risk the package breaking when installed for others.
And because we publish our types with our package, even Type imports should need to be included in dependencies or peerDependencies. So
type-festshould really be listed as a direct dependency (as it is for other major users of type-fest, like yup, snakecase-keys, etc., and as described heresindresorhus/type-fest#136 (comment)).