Loosen peer deps for tiptap packages #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let consumers of the app install newer versions of these various packages if they so choose. It would be nice if this could include packages with versions above 2.0.0-beta.210, but due to https://tiptap.dev/blog/new-pm-package-and-upgrade-guide-for-beta-210 and in particular a change in the table extension, which went from using `@tiptap/prosemirror-tables` to the original `prosemirror-tables` package (via `@tiptap/pm`), so we can't easily support both. We'll bump all tiptap packages to beta.210+ and switch to tiptap/pm separately later.
sjdemartini
added a commit
that referenced
this pull request
Jun 15, 2023
When switching any tiptap package to the beta.210+, we have to use `@tiptap/pm` for all prosemirror stuff exclusively, in order to ensure we have consistent prosemirror package versioning, as described in https://tiptap.dev/blog/new-pm-package-and-upgrade-guide-for-beta-210 And as such this bumps all packages to beta.210+, most notably to get around quirks with the prosemirror-tables extension as described in #45
sjdemartini
added a commit
that referenced
this pull request
Jun 16, 2023
When switching any tiptap package to the beta.210+, we have to use `@tiptap/pm` for all prosemirror stuff exclusively, in order to ensure we have consistent prosemirror package versioning, as described in https://tiptap.dev/blog/new-pm-package-and-upgrade-guide-for-beta-210 And as such this bumps all packages to beta.210+, most notably to get around quirks with the prosemirror-tables extension as described in #45
sjdemartini
added a commit
that referenced
this pull request
Jun 16, 2023
When switching any tiptap package to the beta.210+, we have to use `@tiptap/pm` for all prosemirror stuff exclusively, in order to ensure we have consistent prosemirror package versioning, as described in https://tiptap.dev/blog/new-pm-package-and-upgrade-guide-for-beta-210 And as such this bumps all packages to beta.210+, most notably to get around quirks with the prosemirror-tables extension as described in #45
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let consumers of the app install newer versions of these various packages if they so choose. It would be nice if this could include packages with versions above 2.0.0-beta.210, but due to https://tiptap.dev/blog/new-pm-package-and-upgrade-guide-for-beta-210 and in particular a change in the table extension, which went from using
@tiptap/prosemirror-tablesto the originalprosemirror-tablespackage (via@tiptap/pm), we can't easily support both these versions and beta.210+ (including the non-beta 2.0.0+).We'll bump all tiptap packages to beta.210+ and switch to tiptap/pm separately later.