Fix link bubble menu state when clicking out or changing selection #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids a focus-jump when clicking away from the "Edit" form, by ensuring the bubble menu state is kept in sync. An extra precautionary fallback to `?? ""` is added for the `currentHref` just in case the menu renders when unexpected and no `href` is available, since this can cause a crash (though that scenario is likely resolved by our more deliberate menu-closing, and handled here just as a defensive precaution).
sjdemartini
force-pushed
the
fix-link-menu-clickaway
branch
from
87390b9 to
5a29ae1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids a focus-jump when clicking away from the "Edit" form, by ensuring the bubble menu state is kept in sync. An extra precautionary fallback to
?? ""is added for thecurrentHrefjust in case the menu renders when unexpected and nohrefis available, since this can cause a crash (though that scenario is likely resolved by our more deliberate menu-closing, and handled here just as a defensive precaution).