Use vanilla React for link-editing form, and remove react-hook-form dependency #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds back the bubble menu as a dependency, since otherwise because it's a dependency of the tiptap/react plugin, it would get installed with a higher version that had incompatibilities with our other packages. To get `react-hook-form` to be removed upon install, I had to delete the pnpm-lock file for the example app in order to force it to re-install the package based on its latest package.json definition. Otherwise, in this case, the `react-hook-form` package was not getting removed, since it seems the dependencies of the `file:../` for mui-tiptap were somehow cached.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The form behavior should essentially be identical, but we can reduce the bundle impact and simplify things by reducing external dependencies.