Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict pytest-check to 2.2.2 #906

Merged
merged 1 commit into from
Jan 28, 2025
Merged

Restrict pytest-check to 2.2.2 #906

merged 1 commit into from
Jan 28, 2025

Conversation

bmerry
Copy link
Contributor

@bmerry bmerry commented Jan 28, 2025

Newer versions of pytest-check don't play nice with pytest-reportlog: okken/pytest-check#173

Checklist (if not applicable, edit to add (N/A) and mark as done):

  • If dependencies are added/removed: update setup.cfg and .pre-commit-config.yaml
  • (n/a) If modules are added/removed: use sphinx-apidoc -efo doc/ src/ to update files in doc/
  • (n/a) Ensure copyright notices are present and up-to-date
  • (n/a) If qualification tests are changed: attach a sample qualification report
  • (n/a) If design has changed: ensure documentation is up to date
  • (n/a) If ICD-defined sensors have been added: update fake_servers.py in katsdpcontroller to match

Newer versions of pytest-check don't play nice with pytest-reportlog:
okken/pytest-check#173
Copy link
Contributor

@amishatishpatel amishatishpatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Although, why did it only (seem to) manifest itself so late in the qualification run?

@bmerry
Copy link
Contributor Author

bmerry commented Jan 28, 2025

Good catch. Although, why did it only (seem to) manifest itself so late in the qualification run?

Probably only happens when there is a actually a failure in a pytest_check assertion.

@bmerry bmerry merged commit 7315570 into main Jan 28, 2025
1 of 2 checks passed
@bmerry bmerry deleted the fix-pytest-check branch January 28, 2025 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants