feat(orders): added check that order number is valid as by Luhn algor…

…ithm
skaurus · Jul 3, 2022 · 2ca3da9 · 2ca3da9
1 parent 6d80701
commit 2ca3da9
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 0 deletions.
diff --git a/go.mod b/go.mod
@@ -43,6 +43,7 @@ require (
 	github.com/spf13/cast v1.5.0 // indirect
 	github.com/spf13/jwalterweatherman v1.1.0 // indirect
 	github.com/subosito/gotenv v1.3.0 // indirect
+	github.com/theplant/luhn v0.0.0-20170224032821-81a1a381387a // indirect
 	github.com/ugorji/go/codec v1.2.7 // indirect
 	golang.org/x/crypto v0.0.0-20220622213112-05595931fe9d // indirect
 	golang.org/x/net v0.0.0-20220624214902-1bab6f366d9e // indirect

diff --git a/go.sum b/go.sum
@@ -330,6 +330,8 @@ github.com/stretchr/testify v1.7.2 h1:4jaiDzPyXQvSd7D0EjG45355tLlV3VOECpq10pLC+8
 github.com/stretchr/testify v1.7.2/go.mod h1:R6va5+xMeoiuVRoj+gSkQ7d3FALtqAAGI1FQKckRals=
 github.com/subosito/gotenv v1.3.0 h1:mjC+YW8QpAdXibNi+vNWgzmgBH4+5l5dCXv8cNysBLI=
 github.com/subosito/gotenv v1.3.0/go.mod h1:YzJjq/33h7nrwdY+iHMhEOEEbW0ovIz0tB6t6PwAXzs=
+github.com/theplant/luhn v0.0.0-20170224032821-81a1a381387a h1:8Yp+jFiOdzOTk/YQcKEA/ccK0NQD3LT965HrQgNqd3o=
+github.com/theplant/luhn v0.0.0-20170224032821-81a1a381387a/go.mod h1:ZaMGXj0IgDRrzbd+S4SJEqxUQSOhbsyCbM6hXiIhnXM=
 github.com/ugorji/go v1.2.7/go.mod h1:nF9osbDWLy6bDVv/Rtoh6QgnvNDpmCalQV5urGCCS6M=
 github.com/ugorji/go/codec v1.2.7 h1:YPXUKf7fYbp/y8xloBqZOw2qaVggbfwMlI8WM3wZUJ0=
 github.com/ugorji/go/codec v1.2.7/go.mod h1:WGN1fab3R1fzQlVQTkfxVtIBhWDRqOviHU95kRgeqEY=

diff --git a/internal/app/app_handlers.go b/internal/app/app_handlers.go
@@ -17,6 +17,7 @@ import (
 	jsoniter "github.com/json-iterator/go"
 	"github.com/shopspring/decimal"
 	"github.com/spf13/viper"
+	"github.com/theplant/luhn"
 )
 
 var json = jsoniter.ConfigCompatibleWithStandardLibrary
@@ -173,6 +174,12 @@ func (runEnv Env) handlerOrderRegister(c *gin.Context) {
 		c.String(http.StatusUnprocessableEntity, "order format is wrong")
 		return
 	}
+	intNumber, err := strconv.Atoi(string(orderNumber))
+	if err != nil || !luhn.Valid(intNumber) {
+		logger.Error().Msg("order format is wrong")
+		c.String(http.StatusUnprocessableEntity, "order format is wrong")
+		return
+	}
 
 	order, err := runEnv.orders.Create(c, string(orderNumber), int(user.ID))
 	if err != nil {