Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MariaDB support + dependencies update #92

Merged
merged 9 commits into from
Oct 7, 2024

Conversation

mateuszgorniak
Copy link
Contributor

@mateuszgorniak mateuszgorniak commented Sep 28, 2024

This PR introduces the following changes:

  • DatabaseEngine Class: Enhanced logic to better determine the database engine in use. Added support for the trilogy adapter, which is available for Ruby on Rails applications starting from version 7.1.
  • MariaDB Support: Implemented a proper timeout statement format to ensure full compatibility with MariaDB. This change addresses this issue and should also simplify handling similar cases in the future.
  • Ruby Version Unification: Updated CI workflows and gem configurations to consistently use the latest releases in the Ruby 3.2.x and 3.3.x branches (with preference for the 3.3.x branch).
  • Minor Readability Improvements: Made several small tweaks, including reordering the OPTIONS array, updating dependencies (Ruby, gems, and the PSQL version for GitHub Action workflows), making minor updates to the README file, and removing unused methods from the codebase.

@mateuszgorniak mateuszgorniak force-pushed the mariadb-support branch 25 times, most recently from 953acf5 to 96e18fb Compare September 29, 2024 15:17
@mateuszgorniak mateuszgorniak marked this pull request as ready for review September 29, 2024 15:31
@mateuszgorniak mateuszgorniak changed the title MariaDB support MariaDB support + dependencies update Sep 29, 2024
@skcc321 skcc321 merged commit b32f89c into skcc321:master Oct 7, 2024
13 checks passed
@skcc321
Copy link
Owner

skcc321 commented Oct 7, 2024

Great PR @mateuszgorniak!
Thank you for your contribution.

@mateuszgorniak mateuszgorniak deleted the mariadb-support branch October 12, 2024 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants