Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataTableService exports #478

Closed
niktek opened this issue Oct 31, 2022 · 3 comments
Closed

DataTableService exports #478

niktek opened this issue Oct 31, 2022 · 3 comments
Labels
bug Something isn't working

Comments

@niktek
Copy link
Contributor

niktek commented Oct 31, 2022

Current Behavior

There is currently two exports from DataTableService that are used internally of DataTable.svelte (sortAsc and sortDesc), then there is a mapTableSource that is used in the doc page for data-tables.

On the docs page there is also a CodeBlock that shows an import of import { mapTableSource } from '@brainandbones/skeleton/components/Table/DataTableService'; which I'm pretty sure won't work as the alias @brainandbones/skeleton points to the src/index.ts rather than a directory alias.

What probably needs to happen is that these DataTableService exports need to migrate to the top level src/index.ts file and probably have a bit of a namespace scoping like dtsSortAsc or something like that ?

Steps To Reproduce

No response

Anything else?

No response

@niktek niktek added the bug Something isn't working label Oct 31, 2022
@endigo9740
Copy link
Contributor

@niktek Dupe? #217

Would be easiest if all this info is one place when I finally get to the component again.

@niktek
Copy link
Contributor Author

niktek commented Oct 31, 2022

I'll drop a note over there - just needed to get this fix in as part of the #479 PR

@endigo9740
Copy link
Contributor

The PR looks to be closed, so I've linked to this on the Data Table ticket. Closing this for now. Let's keep data table notes in that ticket. I plan to address those updates as part of this current dev cycle!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants