Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/migrate to using @bnb/skeleton alias #479

Closed
wants to merge 4 commits into from
Closed

Chore/migrate to using @bnb/skeleton alias #479

wants to merge 4 commits into from

Conversation

niktek
Copy link
Contributor

@niktek niktek commented Oct 31, 2022

DO NOT MERGE:
Can't put it into draft mode for some reason.
In preparation for migrating to a monorepo.

  • all doc site pages and components now use @brainandbones/skeleton as the alias as $lib/hardcoded/paths will not exist there post migration.
  • added exports in index.ts for AppRail and AppRailTile - done in separate PR
  • added exports in index.ts for DataTableService.ts and updated data-tables doc page - fixes DataTableService exports #478 (though they are not scoped name wise - not sure if we need to). May no longer be needed.

@vercel
Copy link

vercel bot commented Oct 31, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
skeleton-dev ✅ Ready (Inspect) Visit Preview Oct 31, 2022 at 7:45AM (UTC)

@niktek
Copy link
Contributor Author

niktek commented Oct 31, 2022

I seem to have lost the ability to put this PR back into draft mode :(

@endigo9740 endigo9740 marked this pull request as draft October 31, 2022 17:09
@endigo9740
Copy link
Contributor

I've set it as a draft, but will be curious to hear more about what this entails.

@niktek niktek closed this Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DataTableService exports
2 participants