Fix: Added better types for Toast and fixed issue with actions #587
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting the PR:
npm run test
?branch -m new-branch-name
What does your PR address?
toastStore
console.log
in the store as wellToast actions bug: if you navigate here and press on the following buttons in this order,
Paragraph
thenAction
, you will notice that if you try to press theGreeting
action, the alert won't fire.Additionally, if you close all the toasts and press
Action
, thenParagraph
, followed by pressing theGreeting
action, you'll see that the alert fires this time. But! When the alert closes, theParagraph
toasts closes instead of theAction
toast!Tips