Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Added better types for Toast and fixed issue with actions #587

Merged
merged 3 commits into from
Nov 25, 2022
Merged

Fix: Added better types for Toast and fixed issue with actions #587

merged 3 commits into from
Nov 25, 2022

Conversation

AdrianGonz97
Copy link
Member

@AdrianGonz97 AdrianGonz97 commented Nov 22, 2022

Before submitting the PR:

  • Does your PR reference an issue? If not, please chat to the team on Discord or GitHub before submission.
  • Did you update and run tests before submission using npm run test?
  • Does your branch follow our naming convention? If not, please amend the branch name using branch -m new-branch-name
  • Did you update documentation related to your new feature or changes?

What does your PR address?

  • Adds types for the toastStore
  • Fixes a bug with Toast actions
  • Removed a lost console.log in the store as well

Toast actions bug: if you navigate here and press on the following buttons in this order, Paragraph then Action, you will notice that if you try to press the Greeting action, the alert won't fire.
Additionally, if you close all the toasts and press Action, then Paragraph, followed by pressing the Greeting action, you'll see that the alert fires this time. But! When the alert closes, the Paragraph toasts closes instead of the Action toast!

Tips

  • Tap "convert to draft" to indicate this is work in progress.
  • Link to an issue using the verbiage Fixes #XX
  • Linked issues will auto-close when the PR is merged.

@vercel
Copy link

vercel bot commented Nov 22, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
skeleton-docs ❌ Failed (Inspect) Nov 22, 2022 at 11:09PM (UTC)

@endigo9740
Copy link
Contributor

Thanks @AdrianGonz97 as mentioned on Discord I'll take a look at this asap, but may be take a little time given some other items we're tending do, such as the new CLI. Thanks though!

@endigo9740
Copy link
Contributor

endigo9740 commented Nov 23, 2022

@AdrianGonz97 FYI the Vercel failure in this PR isn't on you. There was a new auto-adapter update for SvelteKit that broke Vercel deploys. We've already did a dependency bump on dev branch which resolved this. Just in case you were wondering!

Also did a quick look over the files. This looks good! Good fixes, and yes very silly. But I'll do a proper review tomorrow and aim to merge asap.

@AdrianGonz97 AdrianGonz97 marked this pull request as ready for review November 23, 2022 13:33
@endigo9740
Copy link
Contributor

@niktek Now that you have access, totally cool with you doing a review and merge of this one. It looks good with a quick visual scan. My procedure is usually as follows:

  1. Pull down with the GH CLI command
  2. Run Vitest to find broad issues
  3. Start the server and manually test.
  4. Report back if anything is off or needs adjusting

I mentioned it above, but the Vercel failure is due to this coming in before the auto-adapter fix that's already on dev branch. This means it should be safe to merge.

@endigo9740
Copy link
Contributor

@AdrianGonz97 I've managed to review and confirm all is good here. Merging now! Thanks for your help!

@endigo9740 endigo9740 merged commit 3bdc9c0 into skeletonlabs:dev Nov 25, 2022
@endigo9740 endigo9740 mentioned this pull request Nov 25, 2022
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants