-
-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Autocomplete component #988
Conversation
Component created, route added to `links.ts`, route created in `routes`. Still need to create autocomplete.css, or some kind of styles file based on what Chris and the others think is best.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@JustBarnt I know you're still in progress but I mentioned I'd do a quick rudimentary scan asap. So here's a few notes.
<div class="page-container">
<!-- (your examples here) -->
</div>
One way to handle this might be to supply a
I'll leave it there for now, but code wise everything is looking clean - great job getting the inline prop docs and following our pattern for applying classes. Don't stress too much about the design, I'll probably have some opinions on that. But that's my area of expertise and can help. Keep me posted when you're ready for another review. Thanks Brent! |
Update autocomplete names to be `Autocomplete` moved it down in the list so its in alphabetical order.
Updated filterValues() to use the `mode` prop to give the user some addition filtering capabilities. The `exclude` filter needs more work. Havign trouble figuring out the best way return a list of items not in the input.
Mode type added with values `exclude` and `fuzzy` this will give the user the options to only pick `exclude` or `fuzzy` when passing a value to the `mode` prop
TODO
@endigo9740 If you get a quick chance to look at this- its much appreciated. I just want to make sure Mainly the Excludes Example
IF I'm correct in that functionality I need some help figuring out how to keep removing from the list as they type. I was thinking would allow or allow users to specify |
@JustBarnt I'll try to squeeze this in once I wrap the Doc Shell updates. Thanks! |
Component created, route added to
links.ts
, route created inroutes
. Still need to create autocomplete.css, or some kind of styles file based on what Chris and the others think is best.Before submitting the PR:
npm run test
?branch -m new-branch-name
What does your PR address?
This is the start of the component, it is still a WIP
Initial route creation and component stubbing.
Tips