Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update outsideTemperature sensor #407

Merged
merged 5 commits into from
Dec 4, 2024
Merged

update outsideTemperature sensor #407

merged 5 commits into from
Dec 4, 2024

Conversation

prvakt
Copy link
Collaborator

@prvakt prvakt commented Dec 4, 2024

outsideTemperature is either taken from AuxiliaryHeating response (if AUXILIARY_HEATING capability is available), otherwise from AirConditioning

@WebSpider
Copy link
Contributor

Please split this up in two PR's:

One for the dependency of the library
One for the sensor update

WebSpider
WebSpider requested changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@WebSpider WebSpider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do the lib dependency seperately

@WebSpider WebSpider added the bugfix This PR contains a bugfix label Dec 4, 2024
WebSpider
WebSpider requested changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@WebSpider WebSpider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this fix! 💪

A few remarks about coding style and consistency with other parts of the code

custom_components/myskoda/sensor.py Outdated Show resolved Hide resolved
custom_components/myskoda/sensor.py Outdated Show resolved Hide resolved
@WebSpider
Copy link
Contributor

Thanks for all your hard work! ❤️

@WebSpider WebSpider merged commit 80b17f3 into skodaconnect:main Dec 4, 2024
3 checks passed
@prvakt prvakt deleted the update-outsideTemperature branch December 13, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WebSpider WebSpider WebSpider approved these changes

Assignees
No one assigned
Labels
bugfix This PR contains a bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@prvakt @WebSpider