-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Image entities for vehicle status #437
Conversation
Implement 2 images, default disabled
Fixes #342 |
question 4: is it updated with the periodical vehicle update? |
I figured, that since it is disabled by default, if you want this bad enough to enable it, you probably want it under sensors. But i don't mind changing it if anyone has a strong opinion on this
I am in favor of handling the state, as long as we know what we want the state to be. I did not have any opinion on this yet, so i decided to leave it undefined for now.
I didn't check :-) Only enabled one to see if it works. Will check and report back in a bit. Update: They are the same for me as well. I will remove one entity. |
If there is an update to the state, the URL should change, triggering an update as part of the |
1 ) asked ChatGPT about the sensor vs diagnostic section and it suggest also sensors :)
2 ) the state of all image entities can be implemented later once we agree what to show. 4 ) I'm running this version for hour with poll interval set to 15 minutes.. Initially the state was correct, then I have opened door but state was never changed, even I see periodical update of all sensors have been triggered, Status Render image was not updated.. |
The |
Still doesnt work, I can see from logs that image url was changed from
to
but image was not updated and last updated timestamp was not changed either... |
Thanks, will continue in the mysteries of the |
From https://developers.home-assistant.io/docs/core/entity/image/
I would assume if the url is updated this would automatically invalidate the cache and force the url to be re-fetched. But maybe that's not happening? |
Rereading that piece of documentation, I think they mean we should implement a "last changed" property ourselves, so did that in last commit. |
We are still missing something. "Last changed" was updated correctly, but image was not changed. I can see in MySkoda app that image has changed and door is now opened, and also new binary sensors which I have created today were updated accordingly but image was not |
I will have a look at that parent class more thoroughly. This will not make v1.16.0. |
Good job! Can confirm it works as expected now ;) |
This adds 2 image entities that can display the vehicle status, as is done in the MySkoda App as well.
The status is related to the window state, door state, bonnet state, etc.
Images are disabled by default, since it probably mostly is interesting to developers of custom cards.
They can be enabled manually in HA when going to the list of entities, and enabling them.