Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix for fix missing main render #463

Merged
merged 3 commits into from
Dec 16, 2024
Merged

fix for fix missing main render #463

merged 3 commits into from
Dec 16, 2024

Conversation

sonar98
Copy link
Contributor

@sonar98 sonar98 commented Dec 16, 2024

With pr #456 the main image render is replaced with exterior_front if unavailable.
Problem is that exterior_front is not available for all vehicles.

If exterior_front is unavailable now exterior_side is used

@sonar98
Update device_tracker.py
24d8bf1 
add check for exterior_front, if unavailable use exterior_side
@sonar98
Update image.py
750f9cb 
add check if exterior_front is available, else use exterior_side
WebSpider
WebSpider requested changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@WebSpider WebSpider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your help on this!

Please have a look at the failed tests, probably running ruff format on your repo will fix them :)

@WebSpider WebSpider added the bugfix This PR contains a bugfix label Dec 16, 2024
@sonar98
Copy link
Contributor Author

sonar98 commented Dec 16, 2024

I think it is fixed now.

@sonar98 sonar98 requested a review from WebSpider December 16, 2024 18:34
WebSpider
WebSpider approved these changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@WebSpider WebSpider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works for now. This probably will be reformatted in the future to make it more readable, but this returns the function

@WebSpider WebSpider merged commit 3f84b0c into skodaconnect:main Dec 16, 2024
3 checks passed
@sonar98 sonar98 mentioned this pull request Dec 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WebSpider WebSpider WebSpider approved these changes

Assignees
No one assigned
Labels
bugfix This PR contains a bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sonar98 @WebSpider