(chore) Config updates: Cache list of seen vins in ConfigEntry #502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should help to prevent ending up in situations such as #494 |
This was referenced Dec 31, 2024
|
Needs a bit more testing still, conversion does not seem to always happen |
WebSpider
changed the title
|
If I understand correctly this will be closed in favor of #528 + future PRs? |
|
No, this has been rewritten to contain only the 'vinlist' config data, that enables a cache of last seen vins |
prvakt
approved these changes
Jan 10, 2025
I've tested it on my install to see if the migration works, and it does. the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to be merged after #528 and adds:
Main use for this is to be able to start up even if the garage endpoint gives us an error.