Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add various suggestions from ludeeus/integration_blueprint #79

Merged
merged 1 commit into from
Oct 10, 2024
Merged

Add various suggestions from ludeeus/integration_blueprint #79

merged 1 commit into from
Oct 10, 2024

Conversation

WebSpider
Copy link
Contributor

This repo is commonly used as a template repo for HACS integrations.
This PR adds from there:

  • VSCode devcontainer setup
  • Dependabot setup
  • Automatic creation of zip archive on release
  • Some tweaks to current CI (limits runs to only main branch)

@WebSpider WebSpider requested review from dvx76 and Prior99 October 9, 2024 09:33
dvx76
dvx76 approved these changes Oct 9, 2024
View reviewed changes
Copy link
Member

@dvx76 dvx76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Not familiar with all of this but not seeing anything that concerns me. Maybe add related instructions/notes in a CONTRIBUTING.md?

@WebSpider
Copy link
Contributor Author

WebSpider commented Oct 10, 2024 •
edited
Loading

I'll add CONTRIBUTING.md in a follow-up PR

@WebSpider WebSpider merged commit 93acdf6 into main Oct 10, 2024
4 checks passed
@WebSpider WebSpider deleted the add-features-from-integration_blueprint branch October 14, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dvx76 dvx76 dvx76 approved these changes

@Prior99 Prior99 Awaiting requested review from Prior99

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WebSpider @dvx76