Fix InvalidCapabilityConfigurationError exceptions #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also fixes #73 |
|
Also fixes #72 |
|
Please have a look at the linter. Code runs fine on my dev install. |
dvx76
force-pushed
the
remove-invalid-capa-error
branch
2 times, most recently
from
f22fe9a to
2cd1838
Compare
|
passing checks now, minor changes to pass pyright and other linters |
Instead of raising an uncaught exception in the entities when the underlying attributes in the MySkoda Vehicle object are (temporarily) missing (None), just return None. HA will show the entities as Unknown. Fixes skodaconnect#49
dvx76
force-pushed
the
remove-invalid-capa-error
branch
from
2cd1838 to
9b0ae86
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of raising an uncaught exception in the entities when the underlying attributes in the MySkoda Vehicle object are (temporarily) missing (None), just return None. HA will show the entities as Unknown.
Fixes #49
Discord discussion: https://discord.com/channels/877164727636230184/1087487796731707402/1295108867755081800
Still need to test this but wanted to get the PR up.