added outsideTemperature into AirConditioning class (#268)

* added outsideTemp to AirConditioning class * update fixtures --------- Co-authored-by: Tomas Prvak <[email protected]>
skodaconnect · Dec 4, 2024 · 313c461 · 313c461
1 parent 3794185
commit 313c461
Show file tree

Hide file tree

Showing 21 changed files with 33 additions and 3 deletions.
diff --git a/fixtures/Octavia2023_w_aux_heating.yaml b/fixtures/Octavia2023_w_aux_heating.yaml
@@ -331,6 +331,7 @@ reports:
       front: INVALID
       rear: INVALID
       unspecified: INVALID
+    outside_temperature: null
   success: true
   type: get
   url: /v2/air-conditioning/TMOCKAA0AA000000

diff --git a/fixtures/citigoe_iv_2021_ne142e2_best_of.yaml b/fixtures/citigoe_iv_2021_ne142e2_best_of.yaml
@@ -263,6 +263,7 @@ reports:
       front: 'OFF'
       rear: 'OFF'
       unspecified: INVALID
+    outside_temperature: null
   success: true
   type: get
   url: /v2/air-conditioning/TMOCKAA0AA000000

diff --git a/fixtures/djapollo_enyaq_85_2025.yaml b/fixtures/djapollo_enyaq_85_2025.yaml
@@ -342,6 +342,7 @@ reports:
       front: 'OFF'
       rear: 'OFF'
       unspecified: INVALID
+    outside_temperature: null
   success: true
   type: get
   url: /v2/air-conditioning/TMOCKAA0AA000000

diff --git a/fixtures/kamiq.yaml b/fixtures/kamiq.yaml
@@ -226,6 +226,7 @@ reports:
       front: INVALID
       rear: INVALID
       unspecified: INVALID
+    outside_temperature: null
   success: true
   type: get
   url: /v2/air-conditioning/TMOCKAA0AA000000

diff --git a/fixtures/karoq-se-l_2023.yaml b/fixtures/karoq-se-l_2023.yaml
@@ -231,6 +231,7 @@ reports:
       front: INVALID
       rear: INVALID
       unspecified: INVALID
+    outside_temperature: null
   success: true
   type: get
   url: /v2/air-conditioning/TMOCKAA0AA000000

diff --git a/fixtures/kodiaq_2024_ps7d6z_exclusive.yaml b/fixtures/kodiaq_2024_ps7d6z_exclusive.yaml
@@ -317,6 +317,7 @@ reports:
       front: INVALID
       rear: INVALID
       unspecified: INVALID
+    outside_temperature: null
   success: true
   type: get
   url: /v2/air-conditioning/TMOCKAA0AA000000

diff --git a/fixtures/nu74nv_karoq_expired_subscription.yaml b/fixtures/nu74nv_karoq_expired_subscription.yaml
@@ -270,6 +270,7 @@ reports:
       front: INVALID
       rear: INVALID
       unspecified: INVALID
+    outside_temperature: null
   success: true
   type: get
   url: /v2/air-conditioning/TMOCKAA0AA000000

diff --git a/fixtures/nx53l5_octavia_2024_combi_deepsleep_0.8.3.yaml b/fixtures/nx53l5_octavia_2024_combi_deepsleep_0.8.3.yaml
@@ -321,6 +321,7 @@ reports:
       front: INVALID
       rear: INVALID
       unspecified: INVALID
+    outside_temperature: null
   success: true
   type: get
   url: /v2/air-conditioning/TMOCKAA0AA000000

diff --git a/fixtures/octavia_2022.yaml b/fixtures/octavia_2022.yaml
@@ -322,6 +322,7 @@ reports:
       front: INVALID
       rear: INVALID
       unspecified: INVALID
+    outside_temperature: null
   success: true
   type: get
   url: /v2/air-conditioning/TMOCKAA0AA000000

diff --git a/fixtures/octavia_iv_2021_nx56xc_combi_rs.yaml b/fixtures/octavia_iv_2021_nx56xc_combi_rs.yaml
@@ -462,6 +462,7 @@ reports:
         unit_in_car: CELSIUS
       window_heating_enabled: null
       air_conditioning_without_external_power: true
+      outside_temperature: null
     error: null
   - type: get
     vehicle_id: 0

diff --git a/fixtures/prior99_enyaq_iv60_idle_full_battery.yaml b/fixtures/prior99_enyaq_iv60_idle_full_battery.yaml
@@ -339,6 +339,7 @@ reports:
       front: 'OFF'
       rear: 'OFF'
       unspecified: INVALID
+    outside_temperature: null
   success: true
   type: get
   url: /v2/air-conditioning/TMOCKAA0AA000000

diff --git a/fixtures/prior99_octavia_2018.yaml b/fixtures/prior99_octavia_2018.yaml
@@ -203,6 +203,7 @@ reports:
       front: INVALID
       rear: INVALID
       unspecified: INVALID
+    outside_temperature: null
   success: true
   type: get
   url: /v2/air-conditioning/TMOCKAA0AA000000

diff --git a/fixtures/skoda_octavia_combi_2023.yaml b/fixtures/skoda_octavia_combi_2023.yaml
@@ -320,6 +320,7 @@ reports:
       front: INVALID
       rear: INVALID
       unspecified: INVALID
+    outside_temperature: null
   success: true
   type: get
   url: /v2/air-conditioning/TMOCKAA0AA000000

diff --git a/fixtures/sonar98_Enyaq_iV80_2022_software_3.0.yaml b/fixtures/sonar98_Enyaq_iV80_2022_software_3.0.yaml
@@ -340,6 +340,7 @@ reports:
       front: 'OFF'
       rear: 'OFF'
       unspecified: INVALID
+    outside_temperature: null
   success: true
   type: get
   url: /v2/air-conditioning/TMOCKAA0AA000000

diff --git a/fixtures/superb_2024_3v35wz_liftback_l_and_k.yaml b/fixtures/superb_2024_3v35wz_liftback_l_and_k.yaml
@@ -472,6 +472,7 @@ reports:
       target_temperature: null
       window_heating_enabled: null
       air_conditioning_without_external_power: null
+      outside_temperature: null
     error: null
   - type: get
     vehicle_id: 0
@@ -515,7 +516,8 @@ reports:
       estimated_date_time_to_reach_target_temperature: null
       outside_temperature:
         temperature_value: 3.0
-        unit_in_car: CELSIUS      
+        unit_in_car: CELSIUS
+        car_captured_timestamp: null      
     error: null
   - type: get
     vehicle_id: 0

diff --git a/fixtures/superb_iv_2020_3v35xc_liftback_l_and_k.yaml b/fixtures/superb_iv_2020_3v35xc_liftback_l_and_k.yaml
@@ -313,6 +313,7 @@ reports:
       front: 'OFF'
       rear: 'OFF'
       unspecified: INVALID
+    outside_temperature: null
   success: true
   type: get
   url: /v2/air-conditioning/TMOCKAA0AA000000

diff --git a/fixtures/superb_iv_2021_3v54xc.yaml b/fixtures/superb_iv_2021_3v54xc.yaml
@@ -322,6 +322,7 @@ reports:
       front: 'OFF'
       rear: 'OFF'
       unspecified: INVALID
+    outside_temperature: null
   success: true
   type: get
   url: /v2/air-conditioning/TMOCKAA0AA000000

diff --git a/fixtures/superb_iv_combi_2022_3V53XC_standing_still.yaml b/fixtures/superb_iv_combi_2022_3V53XC_standing_still.yaml
@@ -320,6 +320,7 @@ reports:
       front: 'OFF'
       rear: 'OFF'
       unspecified: INVALID
+    outside_temperature: null
   success: true
   type: get
   url: /v2/air-conditioning/TMOCKAA0AA000000

diff --git a/fixtures/webspider_enyaq_iv80_parked_deep_sleep_positioning_off.yaml b/fixtures/webspider_enyaq_iv80_parked_deep_sleep_positioning_off.yaml
@@ -339,6 +339,7 @@ reports:
       front: 'OFF'
       rear: 'OFF'
       unspecified: INVALID
+    outside_temperature: null
   success: true
   type: get
   url: /v2/air-conditioning/TMOCKAA0AA000000

diff --git a/myskoda/models/air_conditioning.py b/myskoda/models/air_conditioning.py
@@ -77,6 +77,13 @@ class Config(BaseConfig):
         code_generation_options = [TO_DICT_ADD_BY_ALIAS_FLAG]  # noqa: RUF012
 
 
+@dataclass
+class OutsideTemperature(TargetTemperature):
+    car_captured_timestamp: datetime | None = field(
+        default=None, metadata=field_options(alias="carCapturedTimestamp")
+    )
+
+
 @dataclass
 class WindowHeatingState(DataClassORJSONMixin):
     front: OnOffState
@@ -165,3 +172,6 @@ class AirConditioning(DataClassORJSONMixin):
     air_conditioning_without_external_power: bool | None = field(
         default=None, metadata=field_options(alias="airConditioningWithoutExternalPower")
     )
+    outside_temperature: OutsideTemperature | None = field(
+        default=None, metadata=field_options(alias="outsideTemperature")
+    )
diff --git a/myskoda/models/auxiliary_heating.py b/myskoda/models/auxiliary_heating.py
@@ -9,7 +9,7 @@
 from mashumaro.config import TO_DICT_ADD_BY_ALIAS_FLAG, TO_DICT_ADD_OMIT_NONE_FLAG, BaseConfig
 from mashumaro.mixins.orjson import DataClassORJSONMixin
 
-from .air_conditioning import HeaterSource, TargetTemperature, Timer
+from .air_conditioning import HeaterSource, OutsideTemperature, TargetTemperature, Timer
 
 
 class AuxiliaryState(StrEnum):
@@ -83,6 +83,6 @@ class AuxiliaryHeating(DataClassORJSONMixin):
     estimated_date_time_to_reach_target_temperature: datetime | None = field(
         default=None, metadata=field_options(alias="estimatedDateTimeToReachTargetTemperature")
     )
-    outside_temperature: TargetTemperature | None = field(
+    outside_temperature: OutsideTemperature | None = field(
         default=None, metadata=field_options(alias="outsideTemperature")
     )