Fix Auxiliary Heater for ICE, add outside_temperature (#260)

* added AUXILIARY_HEATING_BASIC capability * added targetTemperature to AuxiliaryHeating class * added auxiliary_heating object to vehicle * added request for auxiliary_heating into get_vehicle() * fixtures updated --------- Co-authored-by: Tomas Prvak <[email protected]>
skodaconnect · Dec 3, 2024 · f81c032 · f81c032
1 parent 71cf54b
commit f81c032
Show file tree

Hide file tree

Showing 5 changed files with 15 additions and 1 deletion.
diff --git a/fixtures/superb_2024_3v35wz_liftback_l_and_k.yaml b/fixtures/superb_2024_3v35wz_liftback_l_and_k.yaml
@@ -171,7 +171,7 @@ reports:
         engine:
           power: 206
           type: TSI
-          capacity_in_liters: 2
+          capacity_in_liters: 2.0
         model: Superb
         title: Škoda Superb
         manufacturing_date: '2023-08-23'
@@ -249,6 +249,8 @@ reports:
             statuses: []
           - id: CARE_AND_INSURANCE
             statuses: []
+          - id: AUXILIARY_HEATING_BASIC
+            statuses: []
       renders:
         - url: >-
             https://iprenders.blob.core.windows.net/base3v3v23200002/0F0FWBQ-6-RemtP8.jqZy0-ZqEczfhG_n50.tUwX-CWwFuhHKJkNPz40df893ms-Has5qeWchF.UzAl13y8jCtnK-CKFEIA-19201080dayvext_front1080.png
@@ -507,6 +509,9 @@ reports:
       target_temperature: null
       car_captured_timestamp: '2024-11-27T07:06:35+00:00'
       estimated_date_time_to_reach_target_temperature: null
+      outside_temperature:
+        temperature_value: 3.0
+        unit_in_car: CELSIUS      
     error: null
   - type: get
     vehicle_id: 0

diff --git a/myskoda/models/auxiliary_heating.py b/myskoda/models/auxiliary_heating.py
@@ -83,3 +83,6 @@ class AuxiliaryHeating(DataClassORJSONMixin):
     estimated_date_time_to_reach_target_temperature: datetime | None = field(
         default=None, metadata=field_options(alias="estimatedDateTimeToReachTargetTemperature")
     )
+    outside_temperature: TargetTemperature | None = field(
+        default=None, metadata=field_options(alias="outsideTemperature")
+    )
diff --git a/myskoda/models/info.py b/myskoda/models/info.py
@@ -25,6 +25,7 @@ class CapabilityId(StrEnum):
     AIR_CONDITIONING_TIMERS = "AIR_CONDITIONING_TIMERS"
     AUTOMATION = "AUTOMATION"
     AUXILIARY_HEATING = "AUXILIARY_HEATING"
+    AUXILIARY_HEATING_BASIC = "AUXILIARY_HEATING_BASIC"
     AUXILIARY_HEATING_TEMPERATURE_SETTING = "AUXILIARY_HEATING_TEMPERATURE_SETTING"
     AUXILIARY_HEATING_TIMERS = "AUXILIARY_HEATING_TIMERS"
     BATTERY_CHARGING_CARE = "BATTERY_CHARGING_CARE"

diff --git a/myskoda/myskoda.py b/myskoda/myskoda.py
@@ -354,6 +354,9 @@ async def get_vehicle(self, vin: str) -> Vehicle:
         if info.is_capability_available(CapabilityId.AIR_CONDITIONING):
             vehicle.air_conditioning = await self.get_air_conditioning(vin)
 
+        if info.is_capability_available(CapabilityId.AUXILIARY_HEATING):
+            vehicle.auxiliary_heating = await self.get_auxiliary_heating(vin)
+
         if info.is_capability_available(CapabilityId.PARKING_POSITION):
             vehicle.positions = await self.get_positions(vin)
 

diff --git a/myskoda/vehicle.py b/myskoda/vehicle.py
@@ -1,6 +1,7 @@
 """Represents a whole vehicle."""
 
 from .models.air_conditioning import AirConditioning
+from .models.auxiliary_heating import AuxiliaryHeating
 from .models.charging import Charging
 from .models.driving_range import DrivingRange
 from .models.health import Health
@@ -18,6 +19,7 @@ class Vehicle:
     charging: Charging | None = None
     status: Status | None = None
     air_conditioning: AirConditioning | None = None
+    auxiliary_heating: AuxiliaryHeating | None = None
     positions: Positions | None = None
     driving_range: DrivingRange | None = None
     trip_statistics: TripStatistics | None = None