Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add charging-complete ServiceEvent #205

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

dvx76
Copy link
Member

@dvx76 dvx76 commented Nov 13, 2024

and new state chargePurposeReachedAndConservation.

Fixes skodaconnect/homeassistant-myskoda#253

@dvx76 dvx76 requested a review from WebSpider November 13, 2024 20:06
@dvx76
Copy link
Member Author

dvx76 commented Nov 13, 2024

adding a test

@dvx76 dvx76 force-pushed the mqtt-charging-complete branch 2 times, most recently from 6dbd61a to f98bf6b Compare November 13, 2024 20:34
and new state `chargePurposeReachedAndConservation`.

Fixes skodaconnect/homeassistant-myskoda#253
@dvx76 dvx76 force-pushed the mqtt-charging-complete branch from f98bf6b to e1e37b2 Compare November 13, 2024 20:37
Copy link
Contributor

@WebSpider WebSpider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@WebSpider WebSpider merged commit 6956d5a into skodaconnect:main Nov 13, 2024
2 checks passed
@WebSpider WebSpider added the enhancement New feature or request label Nov 13, 2024
zaptm pushed a commit to zaptm/myskoda that referenced this pull request Dec 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exception parsing MQTT event 'charging-completed'
2 participants