Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add exception for redirect to marketing consent #284

Merged
merged 2 commits into from
Dec 16, 2024

Conversation

Thor77
Copy link
Contributor

@Thor77 Thor77 commented Dec 15, 2024

during login the process can halt because the user is redirected to a marketing constent page. Without catching this condition a KeyError Location is raised because it's the final page but doesn't start with myskoda://.

Ref #277

during login the process can halt because the user is redirected to a marketing constent page.
Without catching this condition a KeyError Location is raised because it's the final page but doesn't start with `myskoda://`.
@WebSpider WebSpider added the bug Something isn't working label Dec 16, 2024
Copy link
Contributor

@WebSpider WebSpider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@WebSpider WebSpider merged commit 03d373f into skodaconnect:main Dec 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants