Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add set-minimum-charge-limit feature #293

Merged
merged 2 commits into from
Dec 20, 2024
Merged

Add set-minimum-charge-limit feature #293

merged 2 commits into from
Dec 20, 2024

Conversation

prvakt
Copy link
Collaborator

@prvakt prvakt commented Dec 19, 2024

Part of departure timers - used when there is at least 1 active timer. Car will charge to the specified SoC after connecting charging cable and stop charging when specified SoC is reached. Rest is charged using departure timer rules.

@prvakt prvakt added the enhancement New feature or request label Dec 19, 2024
@prvakt prvakt requested a review from WebSpider December 19, 2024 19:10
WebSpider
WebSpider reviewed Dec 19, 2024
View reviewed changes
Copy link
Contributor

@WebSpider WebSpider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have any idea of the errors returned when we pass an impossible parameter, such as - 10,105 or when there is no timer?
If so, it would be great if we could make exceptions for them straight away

WebSpider
WebSpider approved these changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@WebSpider WebSpider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise, lgtm

@WebSpider WebSpider merged commit 374a7c6 into skodaconnect:main Dec 20, 2024
2 checks passed
@WebSpider WebSpider mentioned this pull request Dec 20, 2024
Merged
@prvakt prvakt deleted the set-minimum-charge-limit branch December 30, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WebSpider WebSpider WebSpider approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@prvakt @WebSpider