make steeringWheelPosition and windowHeatingState optional

[prvakt]

related to skodaconnect/homeassistant-myskoda#548

[WebSpider]

This will do what's needed, but do we want to catch and model all error-states from API?
with "state" being "INVALID", this is clearly an error state.

Maybe it is a better idea to let the library throw a proper MySkoda.SerializationError exception in cases like this, so we can generally handle this in the integration and tell the user "whelp, we got a SerializationError and the state is INVALID, so something is wrong with MySkoda servers 🤷 "

[prvakt]

This will do what's needed, but do we want to catch and model all error-states from API? with "state" being "INVALID", this is clearly an error state.

Maybe it is a better idea to let the library throw a proper MySkoda.SerializationError exception in cases like this, so we can generally handle this in the integration and tell the user "whelp, we got a SerializationError and the state is INVALID, so something is wrong with MySkoda servers 🤷 "

Rest of the data from that class is already using Default = None so why not these 2?

I agree that #548 was probably caused by problem on MySkoda side, but response still contains some usable data (timers have been returned) so why to throw it away?

[WebSpider]

Rest of the data from that class is already using Default = None so why not these 2?

I agree that #548 was probably caused by problem on MySkoda side, but response still contains some usable data (timers have been returned) so why to throw it away?

Well, i guess the question is: If the API response indicates it's status is invalid, do we still trust the content of it?

Let's go with this for now, but it may need to.change in the future.

I agree we shouldnt change behaviour completely based on one occurance.

[WebSpider]

Lgtm