Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust PredictiveMaintenanceSettings #39

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

OBerghmans
Copy link
Contributor

Make phone and preferred_channel optional in predictive maintenance setting:

Also made the "phone" print nicer when using the CLI (prints a "-" instead of None)

Copy link
Contributor

@WebSpider WebSpider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, waiting for linter to clear up

@OBerghmans
Copy link
Contributor Author

Linting fails on the scripts directory. I can add the new line at the end of the python script, but I don't know how you would like to solve the namespace-packages finding.

@dvx76
Copy link
Member

dvx76 commented Sep 26, 2024

Linting fails on the scripts directory. I can add the new line at the end of the python script, but I don't know how you would like to solve the namespace-packages finding.

Not something you touched in this PR so no concern. It's just been fixed in another PR anyway I think. Thanks for contributing!

@dvx76 dvx76 merged commit c192709 into skodaconnect:main Sep 26, 2024
1 check failed
@OBerghmans OBerghmans deleted the fix/predictivemaintenance branch October 11, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants