Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Service Partner optional in Info #62

Merged
merged 3 commits into from
Sep 29, 2024

Conversation

maartenla
Copy link
Contributor

@maartenla maartenla commented Sep 29, 2024

If you haven't chosen a Service Partner yet in the app this field is not sent from the API.

If something isn't correct let me know!

@dvx76

Edit: fixes #63 and skodaconnect/homeassistant-myskoda#50

Copy link
Member

@dvx76 dvx76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! There's some minor formatting to change to satisfy the linter. Let me know if it's a problem to update it.

myskoda/models/info.py Outdated Show resolved Hide resolved
Prior99
Prior99 previously approved these changes Sep 29, 2024
Copy link
Contributor

@WebSpider WebSpider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@WebSpider WebSpider requested a review from dvx76 September 29, 2024 19:07
@WebSpider WebSpider merged commit 6f7a509 into skodaconnect:main Sep 29, 2024
2 checks passed
@WebSpider
Copy link
Contributor

Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Field "service_partner" of type ServicePartner is missing in Info instance
4 participants