-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MNT bump version on main #115
Conversation
For my understanding, why |
Because we forgot to do this last time. 0.2 is the version for the branch which is already up under |
So if we do a release now, what version would it package have on pypi? |
0.2. We branch from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR.
@@ -16,7 +16,7 @@ | |||
# Dev branch marker is: 'X.Y.dev' or 'X.Y.devN' where N is an integer. | |||
# 'X.Y.dev0' is the canonical version of 'X.Y.dev' | |||
# | |||
__version__ = "0.1.dev0" | |||
__version__ = "0.3.dev0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
What's up with codecov? It shows these lines to have uncovered changes, even though they were not added in this PR :-/ Also, CI is really strange, doc tests go from 150 sec to 60 min timeouts. |
I don't think codecov is related here anyway. It does go flaky sometimes in my experience. We should merge this one since the release is already out. |
cc @skops-dev/maintainers