Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT bump version on main #115

Merged
merged 1 commit into from
Aug 30, 2022
Merged

Conversation

adrinjalali
Copy link
Member

cc @skops-dev/maintainers

@BenjaminBossan
Copy link
Collaborator

For my understanding, why 0.3.dev0 and skipping 0.2.0?

@adrinjalali
Copy link
Member Author

Because we forgot to do this last time. 0.2 is the version for the branch which is already up under 0.2.X now

@BenjaminBossan
Copy link
Collaborator

So if we do a release now, what version would it package have on pypi?

@adrinjalali
Copy link
Member Author

adrinjalali commented Aug 25, 2022

0.2. We branch from main, then we fix the version on that branch (done already), then bump the version on main, which is this PR.

Copy link
Collaborator

@merveenoyan merveenoyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.

@@ -16,7 +16,7 @@
# Dev branch marker is: 'X.Y.dev' or 'X.Y.devN' where N is an integer.
# 'X.Y.dev0' is the canonical version of 'X.Y.dev'
#
__version__ = "0.1.dev0"
__version__ = "0.3.dev0"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@BenjaminBossan
Copy link
Collaborator

What's up with codecov? It shows these lines to have uncovered changes, even though they were not added in this PR :-/

Also, CI is really strange, doc tests go from 150 sec to 60 min timeouts.

@adrinjalali
Copy link
Member Author

I don't think codecov is related here anyway. It does go flaky sometimes in my experience.

We should merge this one since the release is already out.

@BenjaminBossan BenjaminBossan merged commit 4ac7df5 into skops-dev:main Aug 30, 2022
@adrinjalali adrinjalali deleted the version-0.3 branch August 31, 2022 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants