Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: fixed get_log_level when level = 3 #346

Merged
merged 2 commits into from
Oct 12, 2023
Merged

FIX: fixed get_log_level when level = 3 #346

merged 2 commits into from
Oct 12, 2023

Conversation

EdAbati
Copy link
Contributor

@EdAbati EdAbati commented Apr 19, 2023 •
edited
Loading

When working on #343, I stumbled upon this tiny bug: if one sets the log level equal to 3, the CLI raises a IndexError exception.

Steps to reproduce:

$ skops convert test.pkl -vvv
Traceback (most recent call last):
 ...
IndexError: list index out of range

I added the fix in this PR and also a small test. :)

BenjaminBossan
BenjaminBossan approved these changes Apr 20, 2023
View reviewed changes
Copy link
Collaborator

@BenjaminBossan BenjaminBossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for catching this. Ping @E-Aho

@jot-s-bindra

This comment was marked as off-topic.

Sign in to view
@EdAbati
Copy link
Contributor Author

EdAbati commented Oct 12, 2023

HI @jot-s-bindra , I am happy to help!
since it is not related to this PR, could you make an new issue about the problem you are having? We will move the conversation over there :)

@BenjaminBossan
Copy link
Collaborator

@adrinjalali Feel free to merge, I think this one just slipped under the radar.

@adrinjalali adrinjalali merged commit a6c1ae9 into skops-dev:main Oct 12, 2023
@EdAbati EdAbati deleted the fix-get-log-level branch October 12, 2023 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrinjalali adrinjalali adrinjalali approved these changes

@BenjaminBossan BenjaminBossan BenjaminBossan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@EdAbati @jot-s-bindra @BenjaminBossan @adrinjalali