chai-should: don't update member expressions inside expect calls (#503)

skovhus · Mar 22, 2023 · 1ae676f · 1ae676f
1 parent 5c01c62
commit 1ae676f
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 0 deletions.
diff --git a/src/transformers/chai-should.test.ts b/src/transformers/chai-should.test.ts
@@ -302,11 +302,13 @@ test('converts "called"', () => {
   expectTransformation(
     `
         expect(sinonSpy).to.be.called;
+        expect(sinonSpy).to.be.called();
         expect(sinonSpy).not.to.be.called;
         expect(sinonSpy).to.not.be.called;
         expect(sinonSpy).to.be.not.called;
     `,
     `
+        expect(sinonSpy).toHaveBeenCalled();
         expect(sinonSpy).toHaveBeenCalled();
         expect(sinonSpy).not.toHaveBeenCalled();
         expect(sinonSpy).not.toHaveBeenCalled();
@@ -315,6 +317,19 @@ test('converts "called"', () => {
   )
 })
 
+test('does not convert "fetchMock.called()"', () => {
+  expectTransformation(
+    `
+        expect(fetchMock.called("/url")).to.equal(true);
+        expect(fetchMock.called()).to.equal(true);
+    `,
+    `
+        expect(fetchMock.called("/url")).toBe(true);
+        expect(fetchMock.called()).toBe(true);
+    `
+  )
+})
+
 test('converts "called.exactly(n)"', () => {
   expectTransformation(
     `

diff --git a/src/transformers/chai-should.ts b/src/transformers/chai-should.ts
@@ -197,6 +197,10 @@ export default function transformer(fileInfo, api, options) {
 
   const isExpectCall = (node) => isExpectCallUtil(j, node)
 
+  const isInsideExpectCall = (path) =>
+    findParentOfType(path.parentPath.parentPath, 'CallExpression')?.value.callee.name ===
+    'expect'
+
   const typeOf = (path, value, args, containsNot) => {
     switch (args[0].value) {
       case 'null':
@@ -398,6 +402,7 @@ export default function transformer(fileInfo, api, options) {
           },
         })
         .filter((p) => findParentOfType(p, 'ExpressionStatement'))
+        .filter((p) => !isInsideExpectCall(p))
         .filter((p) => {
           const { value } = p
           const propertyName = value.property.name.toLowerCase()