More chai/sinon patches #315
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #315 +/- ##
==========================================
- Coverage 92.18% 92.09% -0.09%
==========================================
Files 26 26
Lines 1842 1872 +30
Branches 381 392 +11
==========================================
+ Hits 1698 1724 +26
Misses 102 102
- Partials 42 46 +4
Continue to review full report at Codecov.
|
…er tweaks) (#291) Co-authored-by: Dan Beam <[email protected]>
Co-authored-by: Renovate Bot <[email protected]>
Co-authored-by: Renovate Bot <[email protected]>
* check for spread call expressions with context identifier
* change sinon .mockImplementation to support any[]
* support .contains with jsx element
* support .toContain for .text()
* handle .toHavePropery('callCount', n)
|
So you are trying to rewrite the git history here to fix the wrong emails in the commits? Normally one would never rewrite history for the main branch. Let me know why this is important to you. Also feel free to DM (e.g. on twitter). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alright, let me explain what's going on here:
somehow 2 of my corporate emails (1 of which doesn't work) slipped into the author field in 287b1e3. I amended them as https://github.com/danbeam/jest-codemods/commit/0417d3b7096de9074597ed7d411fc28bf67b7102. If you know a better way or would prefer to just leave this as is, it wouldn't be the end of the world; just let me know.
I wrote https://github.com/danbeam/jest-codemods/commit/314ab45d364f1feb01cf92ecbe38fd41db179095 chronologically before Make sinon.stub() mock implementation when nothing is returned (& other tweaks) #291 but forgot to upstream it (whoops) so I'm doing that now.
@catc wrote https://github.com/danbeam/jest-codemods/commit/b4a183f847d99fc7b936f105eaca7207c86afa72 and I wrote https://github.com/danbeam/jest-codemods/commit/e37e88660e72102d82ae941dfcf5509095a58a31 (which is only part of a commit) recently without any weirdness 😛 .