Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ^ semver ranges for dependencies #324

Merged
merged 2 commits into from
Jul 8, 2022
Merged

Conversation

lencioni
Copy link
Contributor

@lencioni lencioni commented Jul 6, 2022

This is a small followup to
#323

Using ^ will allow projects that consume this package as a dependency to
be more flexible with the versions of these dependencies.

cc @danbeam @catc

This is a small followup to
skovhus#323

Using ^ will allow projects that consume this package as a dependency to
be more flexible with the versions of these dependencies.
@codecov
Copy link

codecov bot commented Jul 6, 2022

Codecov Report

Merging #324 (c5476ca) into main (191cbe2) will not change coverage.
The diff coverage is n/a.

❗ Current head c5476ca differs from pull request most recent head 1342155. Consider uploading reports for the commit 1342155 to get more accurate results

@@           Coverage Diff           @@
##             main     #324   +/-   ##
=======================================
  Coverage   92.09%   92.09%           
=======================================
  Files          26       26           
  Lines        1872     1872           
  Branches      392      392           
=======================================
  Hits         1724     1724           
  Misses        102      102           
  Partials       46       46           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 191cbe2...1342155. Read the comment docs.

@danbeam
Copy link
Contributor

danbeam commented Jul 6, 2022

@lencioni because this repo uses RenovateBot, I think we'd wanna ask @skovhus if we can add a rangeStrategy to renovate.json (perhaps update-lockfile, replace, or bump?)

@lencioni
Copy link
Contributor Author

lencioni commented Jul 7, 2022

@danbeam that's worth looking into, but it looks like the default is replace which I think will work just fine

@skovhus skovhus enabled auto-merge (squash) July 8, 2022 07:02
@skovhus skovhus merged commit 5a1a104 into skovhus:main Jul 8, 2022
@skovhus
Copy link
Owner

skovhus commented Jul 8, 2022

@lencioni because this repo uses RenovateBot, I think we'd wanna ask @skovhus if we can add a rangeStrategy to renovate.json (perhaps update-lockfile, replace, or bump?)

Thanks for noticing this, I've recently experimented with Renovate. replace is the default, so I believe Renovate should leave this alone.

@skovhus
Copy link
Owner

skovhus commented Jul 8, 2022

Thanks for this @lencioni!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants