Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow sinon codemod to detect 'sinon' package #326

Merged
merged 3 commits into from
Jul 9, 2022

Conversation

josh-degraw
Copy link
Contributor

Addresses #325

@codecov
Copy link

codecov bot commented Jul 9, 2022

Codecov Report

Merging #326 (cf0c04f) into main (b640f7b) will not change coverage.
The diff coverage is 100.00%.

❗ Current head cf0c04f differs from pull request most recent head 64a968f. Consider uploading reports for the commit 64a968f to get more accurate results

@@           Coverage Diff           @@
##             main     #326   +/-   ##
=======================================
  Coverage   92.09%   92.09%           
=======================================
  Files          26       26           
  Lines        1872     1872           
  Branches      392      393    +1     
=======================================
  Hits         1724     1724           
  Misses        102      102           
  Partials       46       46           
Impacted Files Coverage Δ
src/transformers/sinon.ts 87.50% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b640f7b...64a968f. Read the comment docs.

@skovhus skovhus enabled auto-merge (squash) July 9, 2022 16:00
@skovhus skovhus merged commit b7cdfda into skovhus:main Jul 9, 2022
@skovhus
Copy link
Owner

skovhus commented Jul 9, 2022

Thanks for fixing this. I took the liberty to remove some of the test duplication.

@josh-degraw
Copy link
Contributor Author

I'm not on my computer right now, but I just realized this will probably still miss a case where there are imports from both sinon and sinon-sandbox. I haven't used sinon-sandbox so I don't know if that's a common situation, but I thought I should at least bring that up in hindsight.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants