Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove @babel/* dependencies #356

Merged
merged 3 commits into from
Aug 20, 2022
Merged

Remove @babel/* dependencies #356

merged 3 commits into from
Aug 20, 2022

Conversation

danbeam
Copy link
Contributor

@danbeam danbeam commented Aug 16, 2022

Hey @skovhus 👋 ! Me again.

Is there any reason why @babel/core and @babel/preset-env are in dependencies and not devDependencies?

It doesn't seem like they're consumed from production code anywhere. cc @lencioni

@codecov
Copy link

codecov bot commented Aug 16, 2022

Codecov Report

Merging #356 (2dc05ee) into main (e4d0981) will decrease coverage by 0.10%.
The diff coverage is n/a.

❗ Current head 2dc05ee differs from pull request most recent head ae07f38. Consider uploading reports for the commit ae07f38 to get more accurate results

@@            Coverage Diff             @@
##             main     #356      +/-   ##
==========================================
- Coverage   92.19%   92.09%   -0.11%     
==========================================
  Files          26       26              
  Lines        1896     1872      -24     
  Branches      398      393       -5     
==========================================
- Hits         1748     1724      -24     
  Misses        102      102              
  Partials       46       46              
Impacted Files Coverage Δ
src/transformers/sinon.ts 87.50% <0.00%> (-1.25%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@skovhus
Copy link
Owner

skovhus commented Aug 16, 2022

Is there any reason why @babel/core and @babel/preset-env are in dependencies and not devDependencies?

@babel/core is a peer dependency of @babel/preset-env which is is a peer dependency of jscodeshift. From my understanding the @babel/preset-env might not be needed as we are using fairly recent versions of node:

If that is true, then we should get rid of both @babel/core and @babel/preset-env.

@danbeam
Copy link
Contributor Author

danbeam commented Aug 16, 2022

Is there any reason why @babel/core and @babel/preset-env are in dependencies and not devDependencies?

@babel/core is a peer dependency of @babel/preset-env which is is a peer dependency of jscodeshift. From my understanding the @babel/preset-env might not be needed as we are using fairly recent versions of node:

If that is true, then we should get rid of both @babel/core and @babel/preset-env.

Removing them is fine by me, as well.

@danbeam danbeam changed the title Move @babel/* to devDependencies Remove @babel/* dependencies Aug 16, 2022
@skovhus skovhus enabled auto-merge (squash) August 20, 2022 06:41
@skovhus skovhus merged commit 1ab7bb0 into skovhus:main Aug 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants