chai-should: don't use Jest's alias names #502
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
When transforming a large codebase, I noticed that when chai syntax is transformed to Jest, the matchers are using alias names instead of the default names.
There is a
eslint-plugin-jest
rule that can migrate the method names, but it would be good to do that by default.https://github.com/jest-community/eslint-plugin-jest/blob/main/docs/rules/no-alias-methods.md
The alias names are possibly also getting removed from Jest (jestjs/jest#13164), so this would be a good way to future proof the code.
ping @skovhus