Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sinon: add support for sinon.assert #518

Merged
merged 1 commit into from
Apr 19, 2023
Merged

Conversation

kristerkari
Copy link
Contributor

Attempts to implement most of the sinon.assert matchers in the sinon codemod.

If you have any idea of how to implement more of the sinon.assert matchers, please let me know. Also, the switch statement that I used is not the prettiest one, but at least it is relatively easy to read (suggestions welcome there too).

I used these as documentation for how sinon.assert is used:

ping @skovhus

@codecov
Copy link

codecov bot commented Apr 12, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.09 🎉

Comparison is base (a94e2b5) 92.38% compared to head (ecd7076) 92.47%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #518      +/-   ##
==========================================
+ Coverage   92.38%   92.47%   +0.09%     
==========================================
  Files          26       26              
  Lines        1944     1968      +24     
  Branches      405      407       +2     
==========================================
+ Hits         1796     1820      +24     
  Misses        102      102              
  Partials       46       46              
Impacted Files Coverage Δ
src/transformers/sinon.ts 91.47% <100.00%> (+0.72%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@skovhus skovhus merged commit c59451d into skovhus:main Apr 19, 2023
@skovhus
Copy link
Owner

skovhus commented Apr 19, 2023

Thanks!

@kristerkari kristerkari deleted the sinon-assert branch April 19, 2023 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants