Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeScript: Jasmine types like jasmine.SpyObj and jasmine.Spy should be migrated #611

Merged
merged 5 commits into from
Sep 1, 2024

Conversation

jase88
Copy link
Contributor

@jase88 jase88 commented Aug 30, 2024

fixes #609

Copy link

codecov bot commented Aug 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.73%. Comparing base (a94e2b5) to head (ae507f2).
Report is 68 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #611      +/-   ##
==========================================
+ Coverage   92.38%   92.73%   +0.35%     
==========================================
  Files          26       27       +1     
  Lines        1944     2066     +122     
  Branches      405      425      +20     
==========================================
+ Hits         1796     1916     +120     
  Misses        102      102              
- Partials       46       48       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jase88
Copy link
Contributor Author

jase88 commented Aug 31, 2024

This doesn't cover nested types like

let translateMock: { translate: jasmine.Spy };

or class member declarations like

class Foo {
  something: jasmine.Spy<(value: string) => void>;
}

Many other scenarios are probably not supported either. I think nested types may be worth the effort, but would this be included in a follow up MR

@skovhus skovhus merged commit a332b86 into skovhus:main Sep 1, 2024
3 checks passed
@jase88 jase88 deleted the jasmine-types branch September 3, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeScript Jasmine: Types should be migrated
2 participants