feat(jasmine): add matcher transforms that have no direct equivalent in jest, but can be expressed in other ways #614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in jest, but can be expressed in other ways: added support for toBePositiveInfinity, toBeNegativeInfinity, toHaveSize, toHaveBeenCalledOnceWith, toHaveBeenCalledBefore, toHaveSpyInteractions
jase88
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #614 +/- ##
==========================================
+ Coverage 92.38% 92.77% +0.39%
==========================================
Files 26 27 +1
Lines 1944 2091 +147
Branches 405 425 +20
==========================================
+ Hits 1796 1940 +144
- Misses 102 103 +1
- Partials 46 48 +2 ☔ View full report in Codecov by Sentry. |
skovhus
reviewed
Sep 8, 2024
| @@ -169,6 +183,10 @@ test('maps expect matchers', () => { | |||
| expect(stuff).not.toHaveBeenCalled(); | |||
| expect(stuff).not.toHaveBeenCalled(); | |||
| expect(stuff).toHaveBeenCalledWith('foo', 'bar'); | |||
|
|
|||
| expect(mySpy.mock.calls).toEqual([['foo', 'bar']]); | |||
There was a problem hiding this comment.
Worth double checking this one. I believe it should be mySpy.mock.calls[0], but we miss checking that it is only called once with those arguments.
There was a problem hiding this comment.
the nested array implicitly asserts that mySpy.mock.calls.length === 1
There was a problem hiding this comment.
I didn't realize the array was nested. All good then. 👍🏼
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added support for toBePositiveInfinity, toBeNegativeInfinity, toHaveSize, toHaveBeenCalledOnceWith, toHaveBeenCalledBefore, toHaveSpyInteractions
credits to @puglyfe