fix(jasmine-this
): prevent TS annotations in non-TS files
#624
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #623
This adds an extra check to the
jasmine-this
transform (which is also used in themocha
transform) to ensure that the source file is actually a TS file rather than just using a TS parser before adding any TS annotations. The tests were previously confirming the existence of this bug, as the filename was hardcoded totest.js
, but the test asserted that a TS annotation was added.To test this, I made a backwards-compatible change to the
runPlugin
test util to allow setting the source file name.