Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(jasmine): returnValues() should be transformed to a chain of mockReturnValueOnce() #628

Merged
merged 3 commits into from
Dec 20, 2024

Conversation

jase88
Copy link
Contributor

@jase88 jase88 commented Nov 23, 2024

fixes #627

Copy link

codecov bot commented Nov 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.80%. Comparing base (a94e2b5) to head (224f46b).
Report is 84 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #628      +/-   ##
==========================================
+ Coverage   92.38%   92.80%   +0.41%     
==========================================
  Files          26       27       +1     
  Lines        1944     2098     +154     
  Branches      405      450      +45     
==========================================
+ Hits         1796     1947     +151     
- Misses        102      103       +1     
- Partials       46       48       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jase88
Copy link
Contributor Author

jase88 commented Dec 19, 2024

@skovhus would you mind taking a look? :)

@skovhus skovhus merged commit 681a52c into skovhus:main Dec 20, 2024
3 checks passed
@skovhus
Copy link
Owner

skovhus commented Dec 20, 2024

Thanks!

@jase88 jase88 deleted the fix/jasmine-return-values branch December 20, 2024 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

spyOn.returnValues transformation uses incorrect jest mock function
2 participants