tape: deepEquals is the same as deepEqual #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm not totally sure of this, but it was one of the things that wasn't switched in our codebase.
Codecov Report
@@ Coverage Diff @@
## master #88 +/- ##
=======================================
Coverage 94.84% 94.84%
=======================================
Files 22 22
Lines 1029 1029
=======================================
Hits 976 976
Misses 53 53
Continue to review full report at Codecov.
|
|
@Haroenv thanks for contributing! If you have time it would be great if you would check the aliases here https://github.com/substack/tape and see if we are missing any more. Thank you so much for this PR. |
|
That should be all of the aliases @skovhus |
|
@Haroenv thanks! |
|
Awesome 🔥 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not totally sure of this, but it was one of the things that wasn't switched in our codebase.
Maybe it supports lots of endings with
s?