Fix for #42 Paths are sometimes matched incorrectly making specs fail #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to account the required: false)
path parameters cannot be empty
…nto testEnvironment
now bar_spec is strict baz_spec is report and rspec (the one that is run at a PR) is strict
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #42
now lib/skooma/objects/openapi/keywords/paths.rb is changed heavily to make sure the path_regex that is used to match a request to an endpoint in the specification uses the patterns of the path parameters
this pull request only uses the regex patterns that can be given for path parameters but it does not use the fact that a parameter can have a type like an integer or have a format or enum
despite this, it is at least something