Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MNT] Move linting to ruff #1692

Merged
merged 2 commits into from
Oct 18, 2024
Merged

[MNT] Move linting to ruff #1692

merged 2 commits into from
Oct 18, 2024

Conversation

airookie17
Copy link
Contributor

@airookie17 airookie17 commented Oct 5, 2024 •
edited
Loading

Description

This PR replaces the existing linters flake8 and isort with ruff.

Fixes #1689

Checklist

  • Linked issues (if existing)
  • Amended changelog for large changes (and added myself there as contributor)
  • Added/modified tests
  • Used pre-commit hooks when committing to ensure that code is compliant with hooks. Install hooks with pre-commit install.
    To run hooks independent of commit, execute pre-commit run --all-files

Make sure to have fun coding!

@airookie17 airookie17 mentioned this pull request Oct 5, 2024
Closed
@fkiraly fkiraly added the maintenance Continuous integration, unit testing & package distribution label Oct 8, 2024
@airookie17 airookie17 marked this pull request as ready for review October 8, 2024 23:08
fkiraly
fkiraly requested changes Oct 13, 2024
View reviewed changes
Copy link
Collaborator

@fkiraly fkiraly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I only have a comment about the max line length.

fkiraly
fkiraly approved these changes Oct 13, 2024
View reviewed changes
Copy link
Collaborator

@fkiraly fkiraly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I am happy with this since it is an 1:1 translation.

We should change line length in another PR.

@airookie17
Copy link
Contributor Author

Thanks for the review! I will change the line length in a different PR as suggested.

@fkiraly fkiraly merged commit dd80041 into sktime:main Oct 18, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fkiraly fkiraly fkiraly approved these changes

Assignees
No one assigned
Labels
maintenance Continuous integration, unit testing & package distribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[MNT] move linting to ruff, resolve strange linting behaviour
2 participants
@airookie17 @fkiraly