Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

N-Hits #890

Merged
merged 12 commits into from
Mar 22, 2022
Merged

N-Hits #890

merged 12 commits into from
Mar 22, 2022

Conversation

jdb78
Copy link
Collaborator

@jdb78 jdb78 commented Mar 15, 2022

Description

This PR adds the NHits model.

Checklist

  • Linked issues (if existing)
  • Amended changelog for large changes (and added myself there as contributor)
  • Added/modified tests
  • Used pre-commit hooks when committing to ensure that code is compliant with hooks. Install hooks with pre-commit install.
    To run hooks independent of commit, execute pre-commit run --all-files
  • Added documentation

Make sure to have fun coding!

@codecov-commenter
Copy link

codecov-commenter commented Mar 20, 2022

Codecov Report

Merging #890 (ceee520) into master (8b87736) will increase coverage by 0.12%.
The diff coverage is 88.20%.

@@            Coverage Diff             @@
##           master     #890      +/-   ##
==========================================
+ Coverage   89.13%   89.26%   +0.12%     
==========================================
  Files          24       26       +2     
  Lines        3855     4190     +335     
==========================================
+ Hits         3436     3740     +304     
- Misses        419      450      +31     
Flag Coverage Δ
cpu 89.26% <88.20%> (+0.12%) ⬆️
pytest 89.26% <88.20%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pytorch_forecasting/__init__.py 100.00% <ø> (ø)
pytorch_forecasting/models/nbeats/__init__.py 93.57% <ø> (ø)
pytorch_forecasting/models/nhits/sub_modules.py 79.64% <79.64%> (ø)
pytorch_forecasting/models/base_model.py 88.44% <84.61%> (+0.32%) ⬆️
pytorch_forecasting/models/nhits/__init__.py 97.10% <97.10%> (ø)
pytorch_forecasting/metrics.py 91.75% <100.00%> (+0.90%) ⬆️
pytorch_forecasting/models/__init__.py 100.00% <100.00%> (ø)
pytorch_forecasting/models/nn/__init__.py 100.00% <100.00%> (ø)
...sting/models/temporal_fusion_transformer/tuning.py 96.77% <100.00%> (ø)
pytorch_forecasting/utils.py 83.76% <100.00%> (+2.51%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b87736...ceee520. Read the comment docs.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@jdb78 jdb78 merged commit eea8c16 into master Mar 22, 2022
@jdb78 jdb78 deleted the feature/n-hits branch May 23, 2022 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants