Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/mqf2 #949

Merged
merged 30 commits into from
May 4, 2022
Merged

Feature/mqf2 #949

merged 30 commits into from
May 4, 2022

Conversation

jdb78
Copy link
Collaborator

@jdb78 jdb78 commented Apr 10, 2022

Description

This PR adds the MQF2 loss

Checklist

  • Linked issues (if existing)
  • Amended changelog for large changes (and added myself there as contributor)
  • Added/modified tests
  • Used pre-commit hooks when committing to ensure that code is compliant with hooks. Install hooks with pre-commit install.
    To run hooks independent of commit, execute pre-commit run --all-files

Make sure to have fun coding!

@codecov-commenter
Copy link

codecov-commenter commented Apr 16, 2022

Codecov Report

Merging #949 (4f099fe) into master (b9229c6) will decrease coverage by 0.46%.
The diff coverage is 91.08%.

@@            Coverage Diff             @@
##           master     #949      +/-   ##
==========================================
- Coverage   89.54%   89.07%   -0.47%     
==========================================
  Files          26       32       +6     
  Lines        4284     4661     +377     
==========================================
+ Hits         3836     4152     +316     
- Misses        448      509      +61     
Flag Coverage Δ
cpu 89.07% <91.08%> (-0.47%) ⬇️
pytest 89.07% <91.08%> (-0.47%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pytorch_forecasting/__init__.py 100.00% <ø> (ø)
pytorch_forecasting/models/deepar/__init__.py 96.72% <ø> (-0.06%) ⬇️
pytorch_forecasting/models/rnn/__init__.py 98.88% <ø> (ø)
pytorch_forecasting/metrics/base_metrics.py 80.85% <70.17%> (ø)
pytorch_forecasting/metrics/_mqf2_utils.py 86.48% <86.48%> (ø)
pytorch_forecasting/data/encoders.py 87.95% <87.67%> (-0.35%) ⬇️
pytorch_forecasting/utils.py 84.61% <89.65%> (+0.27%) ⬆️
pytorch_forecasting/data/timeseries.py 93.31% <94.44%> (-0.18%) ⬇️
pytorch_forecasting/data/samplers.py 94.82% <94.82%> (ø)
pytorch_forecasting/metrics/point.py 95.95% <95.95%> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9db87bb...4f099fe. Read the comment docs.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@jdb78 jdb78 merged commit 1a8683f into master May 4, 2022
@jdb78 jdb78 deleted the feature/mqf2 branch May 23, 2022 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants