Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] ngboost survival prediction model #290

Closed
fkiraly opened this issue May 2, 2024 · 3 comments · Fixed by #301
Closed

[ENH] ngboost survival prediction model #290

fkiraly opened this issue May 2, 2024 · 3 comments · Fixed by #301
Labels
feature request New feature or request good first issue Good for newcomers module:survival&time-to-event module for time-to-event prediction aka survival prediction

Comments

@fkiraly
Copy link
Collaborator

fkiraly commented May 2, 2024

The PR #215 has added ngboost as an skpro regressor.

The package can also be invoked for survival prediction, i.e., for using censoring information C as in the skpro survival models.
We should also add a version of the ngboost algorithm for survival prediction, hence.

To avoid user confusion, it might be better to add this as a separate estimator in the survival module, although the two estimators may end up sharing a lot of similarities and hence, possibly, an inheritance tree.

@fkiraly fkiraly added good first issue Good for newcomers feature request New feature or request module:survival&time-to-event module for time-to-event prediction aka survival prediction labels May 2, 2024
@ShreeshaM07
Copy link
Contributor

Should I start working on this issue?

@fkiraly
Copy link
Collaborator Author

fkiraly commented May 6, 2024

If you find it interesting, of course!

Given that you've interfaced ngboost first time round, it should be less work for you than anyone.

@fkiraly
Copy link
Collaborator Author

fkiraly commented May 6, 2024

Perhaps the most useful examples of recently interfaced survival models:

#247
#237

The main additional challenges are:

fkiraly pushed a commit that referenced this issue May 9, 2024
Resolves #290 

This interfaces the `NGBSurvival` model which is part of the `ngboost` package for survival analysis.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request good first issue Good for newcomers module:survival&time-to-event module for time-to-event prediction aka survival prediction
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants