Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure Lyft Client #6

Merged
merged 3 commits into from
Jan 7, 2018
Merged

Restructure Lyft Client #6

merged 3 commits into from
Jan 7, 2018

Conversation

skukx
Copy link
Owner

@skukx skukx commented Jan 7, 2018

This version contains some gem restructuring. Restructures include
switching from HTTParty to Faraday, Client API changes, and doing away
with VCR.

Changes to note are how parameters are passed when making api calls. The
access_token is now passed in separately from the rest of the arguments
forwarded to lyft.
For example:

client.availability.cost access_token: 'access_token',
                         start_lat: 37.7772,
                         start_lng: -122.4233,
                         end_lat: 37.7972,
                         end_lng: -122.4533

Should be changed to:

client.availability.cost access_token: 'access_token',
                         params: {
                           start_lat: 37.7772,
                           start_lng: -122.4233,
                           end_lat: 37.7972,
                           end_lng: -122.4533
                         }

Taylor Scott added 3 commits January 6, 2018 18:00
This version contains some gem restructuring. Restructures include
switching from HTTParty to Faraday, Client API changes, and doing away
with VCR.

Changes to note are how parameters are passed when making api calls. The
access_token is now passed in separately from the rest of the arguments
forwarded to lyft.
For example:
```ruby
client.availability.cost access_token: 'access_token',
                         start_lat: 37.7772,
                         start_lng: -122.4233,
                         end_lat: 37.7972,
                         end_lng: -122.4533
```
Should be changed to:
```ruby
client.availability.cost access_token: 'access_token',
                         params: {
                           start_lat: 37.7772,
                           start_lng: -122.4233,
                           end_lat: 37.7972,
                           end_lng: -122.4533
                         }
```
@skukx skukx merged commit 0a3edf6 into master Jan 7, 2018
@skukx skukx deleted the UPDATE/restructure branch January 7, 2018 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant