Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore TLS failures, conditionally. #114

Merged
merged 2 commits into from
Nov 2, 2023
Merged

Ignore TLS failures, conditionally. #114

merged 2 commits into from
Nov 2, 2023

Conversation

skx
Copy link
Owner

@skx skx commented Nov 2, 2023

This would close #113, if it were tested and confirmed by @StayPirate.

This would close #113, if it were tested and confirmed.
@StayPirate
Copy link
Contributor

It doesn't work for me. I hope I've tested it correctly.

Here is my testing feeds.txt:

/app # cat /root/.rss2email/feeds.txt
https://gitlab.suse.de/security/secbox-image.atom
- template: /templates/default.tmpl
- insecure

Here are the steps I took to build and test the image:

> git clone https://github.com/skx/rss2email.git
> cd rss2email
> git switch 113-insecure
> podman build -t r2e:test .
> podman run --rm -ti --env-file=./.env -v ./a:/root/.rss2email/feeds.txt --name test r2e:test sh
container > ./rss2email cron --verbose ******@protonmail.com
Fetching feed: https://gitlab.suse.de/security/secbox-image.atom
error processing https://gitlab.suse.de/security/secbox-image.atom - Get "https://gitlab.suse.de/security/secbox-image.atom": tls: failed to verify certificate: x509: certificate signed by unknown authority

@StayPirate
Copy link
Contributor

Now that I read the description of the new option carefully I realized that I have to set the option to either true or yes.

And it works with the following feeds.txt config:

https://gitlab.suse.de/security/secbox-image.atom
- template: /templates/default.tmpl
- insecure: true

@StayPirate
Copy link
Contributor

Nice.

/app # ./rss2email cron --verbose ********@protonmail.com
error with config-file /root/.rss2email/feeds.txt - options should be of the form 'key:value', bogus entry found ' insecure', beneath feed https://gitlab.suse.de/security/secbox-image.atom
/app #

@skx skx merged commit 4642bab into master Nov 2, 2023
@skx skx deleted the 113-insecure branch November 2, 2023 20:00
StayPirate added a commit to StayPirate/apu2e4-containers that referenced this pull request Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Per-Feed option to allow HTTPS connections with invalid certificates
2 participants