-
-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds youtube template #127
Conversation
Nice one, it would be handy to have a template to easily use for youtube channels. Thanks for having shared it 👍🏼 |
I'm not sure what to do with this, because on the one hand it's an awesome thing to see, but on the other if it were merged it would probably get ignored when changes were made to the "main" template. I think the best approach might be to move it into a new directory:
I'd be happy to write a README, and update the main README if you moved it there. Does that sound reasonable? |
Could you confirm that we could then simply use it by specifying it as follow?
Or would be required to manually move |
Yes, just specify the path to the local file, as you did there. It doesn't need to be in templates, it just needs to exist somewhere on the users's system, and the path specified beneath the feed. The only magic otherwise is that |
what do you mean with "included as an embedded file within our binary"? Does I use rss2email via its official docker image, can I expect to find |
Yes. Via this line in
That's how
No. The container will only contain (Personally I bind-mount "rss2email.state" to "/app/.rss2email" so I can ensure the container has:
|
In my opinion, it sounds good. I'll create a folder example_template in the root of the project.This folder holds the template along with a README.md that explains how to proper download the template and use it with the youtube feeds. |
Hi @skx, I've successfully created the folder and crafted the README.md according to the provided specifications. Could you please review it and confirm if everything aligns with your expectations? Once approved, I'll proceed with consolidating all the commits into a single, clean commit. Thank you for your time and feedback! Best regards, |
I would probably reword some things, but yeah that looks like a great start and I'd be happy to merge it. |
Adds a new example template folder. In this folder, you'll find the README that describes the purpose of this folder along with the description of youtube.txt template. The template.txt is the youtube template used to retrieve video channel feeds.
Hi @skx Thank you for your patience. I have merged all the commit into one. You can proceed by merging the code in the codebase. Thank you again, |
Hi,
As the title suggested, this pull request adds a new template to handle channel video feeds coming from YouTube.
These feeds can be obtained with the following URL format:
https://www.youtube.com/feeds/videos.xml?channel_id=${CHANNEL_ID}
CHANNEL_ID can be retrieved in the channel URL ( for instance: https://www.youtube.com/channel/${CHANNEL_ID} ) .
The email template provides the video information such as the published date, the author and the description. The description has been obtained by looking at the fields that were not parsed by the default parser of gofeed, in the Extensions attribute.
Feel free to share any suggestions, input or concerns you may have
Thank you,
Fabio